Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with linkchecker #155

Merged
merged 6 commits into from
Sep 6, 2023
Merged

build with linkchecker #155

merged 6 commits into from
Sep 6, 2023

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 4, 2023

This should fail badly b/c we never curated the links in this doc.

Fixed most of them but some are problematic b/c they are slow or I could not find a substitute:

@ocefpaf ocefpaf force-pushed the fix_links branch 3 times, most recently from dfcf26a to 22d8741 Compare September 5, 2023 13:59
@ocefpaf ocefpaf requested a review from MathewBiddle September 5, 2023 14:49
@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 5, 2023

@MathewBiddle I need your advice/help with the following links:

  1. There are two 404 and one 443 in the 2017-06-12-NCEI_RA_archive_history. I could not find alternative links to fix those and. I wonder if we should rearrange the text to remove those links.
  2. The link to https://www.glos.us/code-sprint/ in 2020-12-08-DataToDwC is also timing out.
  3. The IOOS video link https://nccospublicstor.blob.core.windows.net/ioos/ioos_demo_1280.mp4 is a 404.

@MathewBiddle
Copy link
Contributor

Yes, let's rearrange the text in 2017-06-12-NCEI_RA_archive_history.

The line with

https://geo-ide.noaa.gov/wiki/index.php?title=ISO_Namespaces

can be removed.

All of the geoportal links can be adjusted to https://www.ncei.noaa.gov/metadata/geoportal/#searchPanel and https://www.ncei.noaa.gov/metadata/geoportal/#aboutPanel

The GLOS code sprint link should be https://glos.org/2019-code-sprint/

I have no clue what that video is 😢

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 6, 2023

I have no clue what that video is 😢

Yeah. I was curious to see it too. (Even though I added it there I don't remember it.)

@@ -35,6 +35,7 @@ parse:
- substitution

myst_url_schemes: [mailto, http, https] # URI schemes that will be recognized as external URLs in Markdown links
myst_dmath_double_inline: true # Allow display math ($$) within an inline context
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: This was the default but now it must be explicitly selected.

@ocefpaf
Copy link
Member Author

ocefpaf commented Sep 6, 2023

Building the book with a linkchecker is passing now 🎉

@MathewBiddle this one is ready to go. I remove that video BTW.

@MathewBiddle MathewBiddle merged commit 2560224 into ioos:main Sep 6, 2023
7 checks passed
@ocefpaf ocefpaf deleted the fix_links branch September 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants